lkml.org 
[lkml]   [2005]   [Sep]   [2]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 1 Sep 2005 21:07:55 -0700
FromAndrew Morton <>
SubjectRe: Change in NFS client behavior
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> to den 01.09.2005 Klokka 20:45 (-0700) skreiv Andrew Morton:
> > Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > >
> > >  +static inline int do_posix_truncate(struct dentry *dentry, loff_t length)
> > >  +{
> > >  +	/* In SuS/Posix lore, truncate to the current file size is a no-op */
> > >  +	if (length == i_size_read(dentry->d_inode))
> > >  +		return 0;
> > >  +	return do_truncate(dentry, length);
> > >  +}
> > 
> > We have the same optimisation in inode_setattr()...
> 
> Look again. The two are NOT the same.
> 
> The code in inode_setattr() will cause truncate() to erroneously update
> the ctime/mtime.

Of course.  But with your patch, the optimisation in inode_setattr() is
redundant (except for O_TRUNC, perhaps).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-02 04:12    [from the cache]
©2003-2008