lkml.org 
[lkml]   [2005]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Au1x00 8250 uart support.
    >  static _INLINE_ unsigned int serial_in(struct uart_8250_port *up, int offset)
    > {
    > +#ifdef CONFIG_SERIAL_8250_AU1X00
    > + if (up->port.iotype == UPIO_AU)
    > + offset = au_io_in_map[offset];
    > +#endif

    All this ifdef stuff is rather messy. Allowing the driver to specity a map
    in some structure might make more sense.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-19 22:47    [W:0.023 / U:3.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site