lkml.org 
[lkml]   [2005]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix ST 5481 USB driver
    On Mon, Sep 19, 2005 at 04:21:21PM +0200, Karsten Keil wrote:
    > Hi Greg,
    >
    > On Sat, Sep 17, 2005 at 03:26:40PM -0700, Greg KH wrote:
    > > On Sat, Sep 17, 2005 at 11:52:42PM +0200, Karsten Keil wrote:
    > > > // Cancel all USB transfers on this B channel
    > > > + b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
    > > > usb_unlink_urb(b_out->urb[0]);
    > > > + b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
    > >
    > > URB_ASYNC_UNLINK is now gone in 2.6.14-rc1, so this change will break
    > > the build :(
    > >
    >
    > OK, what would be the correct fix ?

    Found out myself, that usb_unlink_urb is always async now, so URB_ASYNC_UNLINK is
    really obsolete and removing the lines should be enough.

    > Documentation/usb/URB.txt still point to URB_ASYNC_UNLINK for such cases.
    >

    Should be adapted too.

    --
    Karsten Keil
    SuSE Labs
    ISDN development
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-19 16:33    [W:0.020 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site