lkml.org 
[lkml]   [2005]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: p = kmalloc(sizeof(*p), )
    From
    Date
    On Sul, 2005-09-18 at 11:06 +0100, Russell King wrote:
    > I completely disagree with the above assertion for the following
    > reasons:

    Ditto, but you forgot #4. People are always getting sizeof(*p) wrong, in
    particular forgetting that p happens to be a void *, or a struct that is
    some generic type not the full space for the more complex object
    allocated, so using (*p) everywhere just causes more memory scribbles.

    If it bugs people add a kmalloc_object macro that is

    #define new_object(foo, gfp) (foo *)kmalloc(sizeof(foo), (gfp))

    then you can

    x = new_object(struct frob, GFP_KERNEL)

    Other good practice in many cases is a single routine which allocates
    and initialises the structure and is used by all allocators of that
    object. That removes duplicate initialisers, stops people forgetting to
    update all cases, allows better debug and far more.

    Alan

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-18 12:41    [W:0.027 / U:89.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site