lkml.org 
[lkml]   [2005]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] bond_main.c: fix device deregistration in init exception path
    From
    From: Andrew Morton <akpm@osdl.org>
    Date: Sat, 17 Sep 2005 23:32:24 -0700

    > The fix is solid enough, although a better comment is needed. Let's
    > let Dave decide whether that was a sane thing to go BUG over..

    The fix is fine and so is the BUG() check.

    Usually, you're supposed to make sure that the very last thing
    you do is register_netdev(), and that all possible errors are
    possible only before that call.

    And that's what BOND basically does, except that it must register
    multiple devices in a loop and therefore cannot follow that rule
    precisely.

    So I've added the patch to my tree, it's fine to do this for a
    special case usage like this one.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-18 09:28    [W:0.019 / U:59.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site