![]() | |||||||||||
Messages in this thread |
On Friday 16 September 2005 22:52, Kyle Moffett wrote: > [CC list trimmed to relevant people, no need to spam Linus' and > Andrew's mailboxes, they have enough to do as it is] > > On Sep 16, 2005, at 15:39:48, Hans Reiser wrote: > > Christoph Hellwig wrote: > >> additinoal comment is that the code is very messy, very different > >> from normal kernel style, full of indirections and thus hard to read. > > > > Most of my customers remark that Namesys code is head and shoulders > > above the rest of the kernel code. So yes, it is different. > > And yet thousands and thousands of people, businesses, etc, say that > the Linux kernel code is miles above all the commercial software out > there. Please leave the worthless rhetoric out of a technical > discussion. The issue stands that in many ways the Reiser4 code does > not exactly follow Documentation/CodingStyle and does not match most > of the rest of the kernel, making it hard to read for other kernel > developers. If you were just doing this forever as an external > kernel patch, nobody would give a damn. On the other hand, you're > trying to get it included in the upstream kernel, which means that > those same "other kernel developers" for whom it is hard to read may > be expected to maintain it until the end of time. Given this, it > seems perfectly reasonable to ask that it be cleaned up. I think it makes sense to supply examples from reiser4 code which you want to be changed. "It's ugly" is not specific enough. -- vda - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2005-09-17 12:54 [from the cache] ©2003-2008 | |||||||||||