lkml.org 
[lkml]   [2005]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 16/28] drivers/usb/input: convert to dynamic input_dev allocation
Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
> On Thursday 15 September 2005 22:53, Andrew Morton wrote:
> > Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > >
> > > Input: convert drivers/iusb/input to dynamic input_dev allocation
> >
> > The absfuzz initialisation in kbtab_probe() got lost.
> >
>
> Looks fine here:
>
> + input_set_abs_params(input_dev, ABS_X, 0, 0x2000, 4, 0);
> + input_set_abs_params(input_dev, ABS_X, 0, 0x1750, 4, 0);
> ^^^

Oh. You mean they replace these?

- kbtab->dev.absfuzz[ABS_X] = 4;
- kbtab->dev.absfuzz[ABS_Y] = 4;

Not a step forward in readability?

>
> Is there something in your tree that not in Linus's yet?
>

Yeah, some stuff, that's why I noticed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-16 06:21    [W:0.076 / U:2.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site