Messages in this thread Patch in this message | | | Subject | [PATCH]FPU context corrupted after resume | From | Shaohua Li <> | Date | Thu, 15 Sep 2005 10:44:18 +0800 |
| |
Hi, mxcsr_feature_mask_init isn't needed in suspend/resume time (we can use boot time mask). And actually it's harmful, as it clear task's saved fxsave in resume. This bug is widely seen by users using zsh.
Signed-off-by: Shaohua Li<shaohua.li@intel.com> ---
linux-2.6.13-root/arch/i386/power/cpu.c | 1 - linux-2.6.13-root/arch/x86_64/kernel/suspend.c | 1 - 2 files changed, 2 deletions(-)
diff -puN arch/i386/power/cpu.c~fpu_reinit_after_resume arch/i386/power/cpu.c --- linux-2.6.13/arch/i386/power/cpu.c~fpu_reinit_after_resume 2005-09-14 09:35:13.000000000 +0800 +++ linux-2.6.13-root/arch/i386/power/cpu.c 2005-09-14 11:00:55.000000000 +0800 @@ -74,7 +74,6 @@ do_fpu_end(void) /* restore FPU regs if necessary */ /* Do it out of line so that gcc does not move cr0 load to some stupid place */ kernel_fpu_end(); - mxcsr_feature_mask_init(); } diff -puN arch/x86_64/kernel/suspend.c~fpu_reinit_after_resume arch/x86_64/kernel/suspend.c --- linux-2.6.13/arch/x86_64/kernel/suspend.c~fpu_reinit_after_resume 2005-09-14 11:02:21.000000000 +0800 +++ linux-2.6.13-root/arch/x86_64/kernel/suspend.c 2005-09-14 11:02:41.000000000 +0800 @@ -82,7 +82,6 @@ do_fpu_end(void) /* restore FPU regs if necessary */ /* Do it out of line so that gcc does not move cr0 load to some stupid place */ kernel_fpu_end(); - mxcsr_feature_mask_init(); } void __restore_processor_state(struct saved_context *ctxt) _
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |