lkml.org 
[lkml]   [2005]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 03/11] [PATCH] forcedeth: Initialize link settings in every nv_open()
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------

    R�diger found a bug in nv_open that explains some of the reports
    with duplex mismatches:
    nv_open calls nv_update_link_speed for initializing the hardware link speed
    registers. If current link setting matches the values in np->linkspeed and
    np->duplex, then the function does nothing.
    Usually, doing nothing is the right thing, but not in nv_open: During
    nv_open, the registers must be initialized because the nic was reset.

    The attached patch fixes that by setting np->linkspeed to an invalid value
    before calling nv_update_link_speed from nv_open.

    Signed-Off-By: Manfred Spraul <manfred@colorfullife.com>
    Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
    Signed-off-by: Chris Wright <chrisw@osdl.org>
    ---
    drivers/net/forcedeth.c | 3 +++
    1 files changed, 3 insertions(+)

    Index: linux-2.6.13.y/drivers/net/forcedeth.c
    ===================================================================
    --- linux-2.6.13.y.orig/drivers/net/forcedeth.c
    +++ linux-2.6.13.y/drivers/net/forcedeth.c
    @@ -1888,6 +1888,9 @@ static int nv_open(struct net_device *de
    writel(NVREG_MIISTAT_MASK, base + NvRegMIIStatus);
    dprintk(KERN_INFO "startup: got 0x%08x.\n", miistat);
    }
    + /* set linkspeed to invalid value, thus force nv_update_linkspeed
    + * to init hw */
    + np->linkspeed = 0;
    ret = nv_update_linkspeed(dev);
    nv_start_rx(dev);
    nv_start_tx(dev);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-15 03:11    [W:0.034 / U:29.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site