[lkml]   [2005]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 01/11] [PATCH] lost fput in 32bit ioctl on x86-64
    -stable review patch.  If anyone has any objections, please let us know.

    This patch adds lost fput in 32bit tiocgdev ioctl on x86-64

    I believe this is a security issues, since user can fget() file as
    many times as he wants to. So file refcounter can be overlapped and
    first fput() will free resources though there will be still structures
    pointing to the file, mnt, dentry etc. Also fput() sets f_dentry and
    f_vfsmnt to NULL, so other file users will OOPS.

    The oops can be done under files_lock and others, so this is really
    exploitable DoS on SMP. Didn't checked it on practice actually.

    (chrisw: Update to use fget_light/fput_light)

    Signed-Off-By: Kirill Korotaev <>
    Signed-Off-By: Maxim Giryaev <>
    Signed-off-by: Chris Wright <>
    arch/x86_64/ia32/ia32_ioctl.c | 17 +++++++++++++----
    1 files changed, 13 insertions(+), 4 deletions(-)

    Index: linux-2.6.13.y/arch/x86_64/ia32/ia32_ioctl.c
    --- linux-2.6.13.y.orig/arch/x86_64/ia32/ia32_ioctl.c
    +++ linux-2.6.13.y/arch/x86_64/ia32/ia32_ioctl.c
    @@ -24,17 +24,26 @@
    static int tiocgdev(unsigned fd, unsigned cmd, unsigned int __user *ptr)

    - struct file *file = fget(fd);
    + struct file *file;
    struct tty_struct *real_tty;
    + int fput_needed, ret;

    + file = fget_light(fd, &fput_needed);
    if (!file)
    return -EBADF;
    + ret = -EINVAL;
    if (file->f_op->ioctl != tty_ioctl)
    - return -EINVAL;
    + goto out;
    real_tty = (struct tty_struct *)file->private_data;
    if (!real_tty)
    - return -EINVAL;
    - return put_user(new_encode_dev(tty_devnum(real_tty)), ptr);
    + goto out;
    + ret = put_user(new_encode_dev(tty_devnum(real_tty)), ptr);
    + fput_light(file, fput_needed);
    + return ret;

    #define RTC_IRQP_READ32 _IOR('p', 0x0b, unsigned int) /* Read IRQ rate */
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-09-15 03:09    [W:0.022 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site