Messages in this thread | | | Date | Tue, 13 Sep 2005 12:30:26 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory() |
| |
On Tue, 13 Sep 2005, Andrew Morton wrote: > Kirill Korotaev <dev@sw.ru> wrote: > > > > maybe it is worth moving vm_acct_memory() out of > > security_vm_enough_memory()? > > I think that would be saner, yes. That means that the callers would call > vm_acct_memory() after security_enough_memory(), if that succeeded.
I don't like that at all. The implementation of its tests is necessarily imprecise, but nonetheless, we do prefer primitives which atomically test and reserve. We're not moving from request_region to check_region, are we?
But change the naming by all means, it was never good, and grew worse when "security_" got stuck on the front.
Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |