lkml.org 
[lkml]   [2005]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()
    On Mon, 12 Sep 2005, Andrew Morton wrote:
    > Kirill Korotaev <dev@sw.ru> wrote:
    > >
    > > This patch fixes error path in setup_arg_pages() functions, since it
    > > misses vm_unacct_memory() after successful call of
    > > security_vm_enough_memory(). Also it cleans up error path.
    >
    > Ugh. The identifier `security_vm_enough_memory()' sounds like some
    > predicate which has no side-effects. Except it performs accounting. Hence
    > bugs like this.
    >
    > It's a shame that you mixed a largeish cleanup along with a bugfix - please
    > don't do that in future.
    >
    > Patch looks OK to me. Hugh, could you please double-check sometime?

    It's a good find, and the patch looks correct to me, so far as it goes.
    But I think it's the wrong patch, and incomplete: it can be done more
    appropriately, more simply and more completely in insert_vm_struct itself.
    I'll post a replacement patch (or admit I'm wrong) in a little while.

    Hugh
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-13 13:23    [W:0.029 / U:29.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site