Messages in this thread | | | Date | Tue, 13 Sep 2005 12:33:28 +0200 | From | Markus Lidel <> | Subject | Re: [PATCH 0/2] Couple of I2O sysfs changes |
| |
Hello,
Dmitry Torokhov wrote: > I was looking at the users of class_interfaces and stumbled across > I2O subsystem. As far as I understand the purpose of class interfaces > was to provide different 'views' on the hardware, not just to have > a callback to finish initialization of sysfs structures. I think it > woudl be better to remove i2o_device_class_interface and create > user/parent links right after class device registration.
OK, think i've misunderstood the description of the class interface :-(
> Also, it looks like i2o_device_class itself is not needed - correct > me if I am wrong, but all i2o devics reside on their own bus so > i2o_devices class simply mirrors iformation from the bus and can > also be safely removed.
Nope, there is one bus per controller not per device...
> Please consider applying the 2 pathes below (just compile-tested, > don't have proper hardware).
I'll try to merge the changes (and some other patches) in the near future and provide a changed patch...
Thank you very much.
Best regards,
Markus Lidel ------------------------------------------ Markus Lidel (Senior IT Consultant)
Shadow Connect GmbH Carl-Reisch-Weg 12 D-86381 Krumbach Germany
Phone: +49 82 82/99 51-0 Fax: +49 82 82/99 51-11
E-Mail: Markus.Lidel@shadowconnect.com URL: http://www.shadowconnect.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |