lkml.org 
[lkml]   [2005]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Missing #include <config.h>
    On Tue, Sep 13, 2005 at 07:57:30PM +0200, Geert Uytterhoeven wrote:
    > On Tue, 13 Sep 2005, Christoph Hellwig wrote:
    > > On Tue, Sep 13, 2005 at 03:08:26PM +0100, Russell King wrote:
    > > > On Tue, Sep 13, 2005 at 02:56:23PM +0100, J?rn Engel wrote:
    > > > > After spending some hours last night and this morning hunting a bug,
    > > > > I've found that a different include order made a difference. Some
    > > > > files don't work correctly, unless config.h is included before.
    > > >
    > > > I'm still of the opinion that we should add
    > > >
    > > > -imacros include/linux/config.h
    > > >
    > > > to the gcc command line and stop bothering with trying to get
    > > > linux/config.h included into the right files and not in others.
    > > > (which then means we can eliminate linux/config.h from all files.)
    > >
    > > Yes, absolutely. That would help fixing lots of mess.
    >
    > What about dependencies? Would it cause a recompile of everything if config.h
    > is changed?

    -imacros include/linux/autoconf.h doesn't leak into the dependencies so
    it's fine.

    > Ah, I guess not, since config.h is filtered out of the deps anyway and
    > replaced by a smarter dependency on the correct CONFIG_*, right?

    According to my .*.cmd files, apparantly so.

    --
    Russell King
    Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
    maintainer of: 2.6 Serial core
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-13 20:05    [W:0.030 / U:0.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site