![]() | |||||||||||||
Messages in this thread |
On Monday 12 September 2005 23:43, Pekka Enberg wrote: > On 9/13/05, Jiri Slaby <jirislaby@gmail.com> wrote: > > >- cls = kmalloc(sizeof(struct class), GFP_KERNEL); > > >+ cls = kzalloc(sizeof(struct class), GFP_KERNEL); > > > > > > > > maybe, the better way is to write `*cls' instead of `struct class', > > better for further changes > > Please note that some maintainers don't like it. I at least could not > sneak in patches like these to drivers/usb/ because I had changed > sizeof. > And given the fact that Greg maintains driver core it probably won't be accepted here either :) FWIW I also prefer spelling out the structure I am allocating. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-09-13 05:35 [from the cache] ©2003-2008 | |||||||||||||