Messages in this thread | | | Date | Mon, 12 Sep 2005 13:23:52 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory() |
| |
Kirill Korotaev <dev@sw.ru> wrote: > > This patch fixes error path in setup_arg_pages() functions, since it > misses vm_unacct_memory() after successful call of > security_vm_enough_memory(). Also it cleans up error path.
Ugh. The identifier `security_vm_enough_memory()' sounds like some predicate which has no side-effects. Except it performs accounting. Hence bugs like this.
It's a shame that you mixed a largeish cleanup along with a bugfix - please don't do that in future.
Patch looks OK to me. Hugh, could you please double-check sometime? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |