Messages in this thread |  | | | Date | Sat, 10 Sep 2005 19:47:15 -0400 | | From | Jeff Garzik <> | | Subject | Re: [GIT PATCH] More PCI patches for 2.6.13 |
| |
Alistair John Strachan wrote: > On Saturday 10 September 2005 22:58, Jeff Garzik wrote: > >>Linus Torvalds wrote: >> >>>Case closed. >>> >>>Bogus warnings are a _bad_ thing. They cause people to write buggy code. >>> >>>That drivers/pci/pci.c code should be simplified to not look at the error >>>return from pci_set_power_state() at all. Special-casing EIO is just >>>another bug waiting to happen. >> >>As a tangent, the 'foo is deprecated' warnings for pm_register() and >>inter_module_register() annoy me, primarily because they never seem to >>go away. >> >>The only user of inter_module_xxx is CONFIG_MTD -- thus the deprecated >>warning is useless to 90% of us, who will never use MTD. As for >>pm_register(), there are tons of users remaining. As such, for the >>forseeable future, we will continue to see pm_register() warnings and >>ignore them -- thus they are nothing but useless build noise. >> >>I've attached a patch, just tested, which addresses inter_module_xxx by >>making its build conditional on the last remaining user. This solves >>the deprecated warning problem for most of us, and makes the kernel >>smaller for most of us, at the same time. > > > Though external modules using these functions will be hung out to dry. But > only if you don't select CONFIG_MTD? That's not particularly intuitive. > > It's better to mark it deprecated (which has been done), then officially > remove it (and all in-tree users) once and for all. Compiling the code > conditionally just to avoid a few warnings is a silly idea.
Presumably David Woodhouse (MTD maintainer) would yell if we just ripped out the in-tree users.
It is even more silly to continue compiling code that is dead for almost everybody.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |