lkml.org 
[lkml]   [2005]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] include: pci_find_device remove (include/asm-i386/ide.h)
    Greg KH wrote:
    > On Sat, Sep 10, 2005 at 04:55:10PM -0400, Jeff Garzik wrote:
    >
    >>Jiri Slaby wrote:
    >>
    >>>diff --git a/include/asm-i386/ide.h b/include/asm-i386/ide.h
    >>>--- a/include/asm-i386/ide.h
    >>>+++ b/include/asm-i386/ide.h
    >>>@@ -41,7 +41,12 @@ static __inline__ int ide_default_irq(un
    >>>
    >>>static __inline__ unsigned long ide_default_io_base(int index)
    >>>{
    >>>- if (pci_find_device(PCI_ANY_ID, PCI_ANY_ID, NULL) == NULL) {
    >>>+ struct pci_dev *pdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
    >>>+ unsigned int a = !pdev;
    >>>+
    >>>+ pci_dev_put(pdev);
    >>
    >>
    >>Looks like we need to resurrect pci_present() from the ancient past.
    >
    >
    > Heh, ick, no :)
    >
    > Jiri, any other way to do this instead?

    Look at what the IDE code is trying to do. All it cares about is
    whether -any PCI device at all- is present, a boolean value.

    Jeff


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-10 23:42    [W:0.021 / U:0.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site