lkml.org 
[lkml]   [2005]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Jeff Garzik napsal(a):
> Jiri Slaby wrote:
>
>> Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>
>>
>> specialix.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/char/specialix.c b/drivers/char/specialix.c
>> --- a/drivers/char/specialix.c
>> +++ b/drivers/char/specialix.c
>> @@ -2502,9 +2502,9 @@ static int __init specialix_init(void)
>> i++;
>> continue;
>> }
>> - pdev = pci_find_device (PCI_VENDOR_ID_SPECIALIX,
>> - PCI_DEVICE_ID_SPECIALIX_IO8,
>> - pdev);
>> + pdev = pci_get_device (PCI_VENDOR_ID_SPECIALIX,
>> + PCI_DEVICE_ID_SPECIALIX_IO8,
>> + pdev);
>> if (!pdev) break;
>>
>> if (pci_enable_device(pdev))
>> @@ -2517,7 +2517,10 @@ static int __init specialix_init(void)
>> sx_board[i].flags |= SX_BOARD_IS_PCI;
>> if (!sx_probe(&sx_board[i]))
>> found ++;
>> +
>> }
>> + if (i >= SX_NBOARD)
>> + pci_dev_put(pdev);
>
>
> should be converted to PCI probing, rather than this.
I won't do that, i did that for 2 drivers and nobody was interested in
that (and its much time left for nothing). These (unrewritten) drivers
would be deleted in some time. Greg wants simply wipe this function out.

regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-10 23:03    [from the cache]
©2003-2011 Jasper Spaans