Messages in this thread | | | Date | Thu, 1 Sep 2005 10:17:53 +0200 | From | Ingo Molnar <> | Subject | Re: [patch] drivers/ide/pci/alim15x3.c SMP fix |
| |
* Rui Nuno Capela <rncbc@rncbc.org> wrote:
> Ingo Molnar wrote: > >is this the right way to fix the UP assumption below? > > > > Ingo > > > >Signed-off-by: Ingo Molnar <mingo@elte.hu> > > > >Index: linux/drivers/ide/pci/alim15x3.c > > [snip] > > OK. The reported boot WARNING seems to be over now. Tested on the > offended laptop (P4@2.53Ghz/UP, PCI chipset: ALi M1533) with > 2.6.13-rt3, where the suggested patch on drivers/ide/pci/alim15x3.c > seems to fix the burp. All seems to be working fine, still ;)
just to make sure the original point gets across: the warning is only in the -rt tree, and it pinpoints potential SMP bugs. Does your box do hyperthreading? If yes then this could be a live (but probably mostly harmless) SMP bug. Maybe the whole IRQ disabling is unnecessary? __devinit is mostly serialized, so i'm not sure there's any protection needed against parallel IRQs?
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |