Messages in this thread | | | Date | Thu, 01 Sep 2005 18:03:54 -0500 | From | Corey Minyard <> | Subject | Re: [RFC][CFLART] ipmi procfs bogosity |
| |
Andrew Morton wrote:
>Corey Minyard <minyard@acm.org> wrote: > > >>Indeed, this function is badly written. In rewriting, I couldn't find a >> nice function for reading integers from userspace, and the proc_dointvec >> stuff didn't seem terribly suitable. >> >> > >We write numbers into profs files all the time. Is there something >different about the IPMI requirement which makes the approach used by, say, >dirty_writeback_centisecs_handler() inappropriate? > > Ok, that's probably better, and this probably belongs in /proc/sys/dev/ipmi. This is new enough that it doesn't matter, I don't think any one is using it yet.
Patch is attached.
-Corey [unhandled content-type:unknown/unknown] | |