lkml.org 
[lkml]   [2005]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] pci: Block config access during BIST (resend)
    Brian King <brking@us.ibm.com> wrote:
    >
    > +void pci_block_user_cfg_access(struct pci_dev *dev)
    > +{
    > + unsigned long flags;
    > +
    > + pci_save_state(dev);
    > + spin_lock_irqsave(&pci_lock, flags);
    > + dev->block_ucfg_access = 1;
    > + spin_unlock_irqrestore(&pci_lock, flags);

    Are you sure the locking in here is meaningful? All it will really do is
    give you a couple of barriers.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-09-02 01:04    [W:0.021 / U:29.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site