Messages in this thread | | | From | James.Smart@Emulex ... | Subject | FW: [PATCH] shorten workqueue name length | Date | Tue, 9 Aug 2005 12:39:51 -0400 |
| |
Can anyone give some history on why the workqueue name length is limited to 10 characters ? Can it be raised ? and if so to what limit ?
-- James S
-----Original Message----- From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org]On Behalf Of Christoph Hellwig Sent: Tuesday, August 09, 2005 12:32 PM To: Smart, James Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH] shorten workqueue name length
On Tue, Aug 09, 2005 at 12:07:12PM -0400, James.Smart@Emulex.Com wrote: > A customer passed this fix to me... > > In a system with double-digit adapter counts, after a few > rmmod/insmod attempts, the system oops. It always occurs when > the scsi host number reaches 100. > > What is happening is that scsi_add_host() detects a transport that > needs to allocate a workqueue, thus calls create_singlethread_workqueue(). > It hits a BUG_ON() in kernel/workqueue.c:__create_workqueue() which > ensures the length of the name for the workqueue is 10 characters or less. > As the name is "scsi_wq_100", we have exceeded the 10 character max. > > I assume there's good reason for the name to be 10 or less. So what I've > done is shorten the name for the workqueue. Should work until the host number > reaches 10000.
I'd suggest just killing that limit in workqueue.c
- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |