lkml.org 
[lkml]   [2005]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 1/1] x86_64: Rename KDB_VECTOR to DEBUGGER_VECTOR
    Date
    On Tue, 9 Aug 2005 01:16:37 +0200, 
    Andi Kleen <ak@suse.de> wrote:
    >On Tue, Aug 09, 2005 at 09:14:52AM +1000, Keith Owens wrote:
    >> On Mon, 8 Aug 2005 21:28:50 +0200,
    >> Andi Kleen <ak@suse.de> wrote:
    >> >On Mon, Aug 08, 2005 at 12:27:10PM -0700, Tom Rini wrote:
    >> >> {
    >> >> unsigned int icr = APIC_DM_FIXED | shortcut | vector | dest;
    >> >> - if (vector == KDB_VECTOR)
    >> >> + if (vector == NMI_VECTOR)
    >> >> icr = (icr & (~APIC_VECTOR_MASK)) | APIC_DM_NMI;
    >> >
    >> >That if () should be removed since it's useless.
    >> >Can you do that please?
    >>
    >> Why is 'if ()' useless? Remove the if test and all ipis get sent as
    >> NMI, we definitely do not want that.
    >
    >The if () with its following line. The same result can be gotten
    >by passing suitable arguments.

    Arguments to what? The path for sending the NMI_VECTOR is
    send_IPI_allbutself -> {cluster,flat,physflat}_send_IPI_allbutself ->
    {__send_IPI_shortcut, physflat_send_IPI_mask, cluster_send_IPI_mask} ->
    send_IPI_mask_sequence -> __prepare_ICR.

    Pushing the check for NMI_VECTOR any higher than __prepare_ICR needs
    multiple tests for NMI_VECTOR.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-08-09 01:42    [W:0.033 / U:60.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site