Messages in this thread | | | Date | Mon, 08 Aug 2005 19:19:17 +0200 | From | Thomas Winischhofer <> | Subject | Re: [PATCH] drivers/video/sis/ macros for old kernels removal |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Arjan van de Ven wrote: > On Mon, 2005-08-08 at 17:23 +0200, Jiri Slaby wrote: > > Jiri Slaby napsal(a): > > >>> This patch removes some #ifs, which controls kernel version (2.4 or >>> like), so the code could be removed with the macros. >>> linux/version.h inclusions also removed. >> >> Sorry, this was bad idea. X includes some of these file, doesn't it? > > X can't depend on the version of the kernel anyway; the "version" in > version.h has no relation with the running kernel anyway (or with the > version of the kernel that will be used to run the X binaries on)
No good idea anyway. X does, of course, not "include" these files, but they are reused. I don't want to maintain two different versions of the files.
Furthermore, I have a quite big sisfb update in the queue which I intend to submit after 2.6.13 is out. It, amongst others, removes a lot of 2.4 related stuff.
It's best to leave it alone for now.
Thomas
- -- Thomas Winischhofer Vienna/Austria thomas AT winischhofer DOT net http://www.winischhofer.net/
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFC95QVzydIRAktyUcRAkrHAJ98HUOIk7LjHQKWhgMVQqqaiH4mQACePYeG Xl3yGGJeINOsgTT2FOdpQI8= =aItr -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |