lkml.org 
[lkml]   [2005]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] Remove suspend() calls from shutdown path
    From
    Date
    Hi Andrew !

    This patch remove the calls to device_suspend() from the shutdown path
    that were added sometime during 2.6.13-rc*. They aren't working properly
    on a number of configs (I got reports from both ppc powerbook users and
    x86 users) causing the system to not shutdown anymore.

    I think it isn't the right approach at the moment anyway. We have
    already a shutdown() callback for the drivers that actually care about
    shutdown and the suspend() code isn't yet in a good enough shape to be
    so much generalized. Also, the semantics of suspend and shutdown are
    slightly different on a number of setups and the way this was patched in
    provides little way for drivers to cleanly differenciate. It should have
    been at least a different message.

    For 2.6.13, I think we should revert to 2.6.12 behaviour and have a
    working suspend back.

    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    Index: linux-work/kernel/sys.c
    ===================================================================
    --- linux-work.orig/kernel/sys.c 2005-08-01 14:03:46.000000000 +0200
    +++ linux-work/kernel/sys.c 2005-08-04 11:32:51.000000000 +0200
    @@ -404,7 +404,6 @@
    {
    notifier_call_chain(&reboot_notifier_list, SYS_HALT, NULL);
    system_state = SYSTEM_HALT;
    - device_suspend(PMSG_SUSPEND);
    device_shutdown();
    printk(KERN_EMERG "System halted.\n");
    machine_halt();
    @@ -415,7 +414,6 @@
    {
    notifier_call_chain(&reboot_notifier_list, SYS_POWER_OFF, NULL);
    system_state = SYSTEM_POWER_OFF;
    - device_suspend(PMSG_SUSPEND);
    device_shutdown();
    printk(KERN_EMERG "Power down.\n");
    machine_power_off();

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-08-04 11:45    [W:0.021 / U:125.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site