Messages in this thread | | | Date | Thu, 4 Aug 2005 11:16:40 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] updated - Automatically enable bigsmp when we have more than 8 CPUs |
| |
On Wed, Aug 03, 2005 at 04:01:14PM -0700, Venkatesh Pallipadi wrote: > > Below is the updated patch.
Looks good. Only minor nit.
> +++ linux-2.6.13-rc3-auto/arch/i386/kernel/setup.c 2005-08-03 14:33:34.450182216 -0700 > @@ -1593,8 +1594,13 @@ void __init setup_arch(char **cmdline_p) > */ > acpi_boot_table_init(); > acpi_boot_init(); > -#endif > > +#ifdef CONFIG_X86_PC > + if (def_to_bigsmp) { > + printk(KERN_WARNING "More than 8 CPUs detected and CONFIG_X86_PC cannot handle it. Use CONFIG_X86_GENERICARCH or CONFIG_X86_BIGSMP.\n");
Isn't that printk line longer than 80 characters? Will it even fit on the screen?
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |