lkml.org 
[lkml]   [2005]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 04/16] I/O driver for 8250-compatible UARTs
On Wed, Aug 31, 2005 at 03:19:37PM -0600, Bjorn Helgaas wrote:
> On Wednesday 31 August 2005 2:10 pm, Tom Rini wrote:
> > On Wed, Aug 31, 2005 at 01:38:52PM -0600, Bjorn Helgaas wrote:
> > > On Monday 29 August 2005 10:09 am, Tom Rini wrote:
> > I've tried intentionally to not mention 'ttyS' anywhere (exposed to the
> > user) because it's really not 'ttySN' but it is the port registered to
> > us.
>
> So kgdb's port N is different from ttySN? That sounds really
> confusing. And KGDB_SIMPLE_SERIAL does mention "ttyS".

It's not intentionally different, and really only might be different in
the we have ttySX case, but ttySX isn't registered to KGDB case.

> > There's really two cases we have to deal with. The first case is a
> > known at compile time or can be registered at boot-time easily port (ie
> > dumb old PC or ARM boards). The second case is "serial port over
> > there". Perhaps we should change the kgdb8250 arg to be an override of
> > the default port, so:
> > kgdb8250={io,mmio},<irq>,<token>,<baud rate>
>
> That makes sense. But I'd make it {io,mmio},<token>,<baud>,<irq>
> so it's more like the existing "console=uart" argument.

ok.

> > > > + printk(KERN_ERR "kgdb8250: argument error, usage: "
> > > > + "kgdb8250=<port number>,<baud rate>");
> > > > +#ifdef CONFIG_IA64
> > > > + printk(",<irq>,<iomem base>");
> > > > +#endif
> > >
> > > This isn't ia64-specific.
> >
> > It is and it isn't. Since no one's tried a PCI card uart for KGDB nor
> > had a case where we have to pass in the mmio addr except on ia64, it is
> > ia64-specific.
>
> Maybe it's only been *tested* on ia64, but I don't think that's a
> reason to make it compiled only on ia64.

It's only been needed on ia64. But it's moot since I've reworked things
for kgdb8250= is always a complete override.

> Actually, I think KGDB_SIMPLE_SERIAL, KGDB_*BAUD, KGDB_PORT_*,
> KGDB_PORT, and KGDB_IRQ are overkill. Could they all be nuked
> in favor of a KGDB_8250_DEVICE that could be set to things like
> "ttyS0,115200" or "io,0x3f8,115200,49"?

Hmm. I'll give that a shot momentarily... That sounds like a good idea
'tho..

--
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-09-01 00:32    [W:0.502 / U:0.384 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site