lkml.org 
[lkml]   [2005]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] libata: add ATAPI module option
Jeff Garzik wrote:
>
> -#ifndef ATA_ENABLE_ATAPI
> - if (unlikely(dev->class == ATA_DEV_ATAPI))
> - return NULL;
> -#endif
> + if (atapi_enabled) {
> + if (unlikely(dev->class == ATA_DEV_ATAPI))
> + return NULL;
> + }
..

Is that if-stmt the right way around?
At first glance, I'd expect it to read:

if (!atapi_enabled) {
...

Cheers!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-31 01:57    [W:0.067 / U:1.080 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site