Messages in this thread | | | Subject | Re: Calling suspend() in halt/restart/shutdown -> not a good idea | From | Benjamin Herrenschmidt <> | Date | Wed, 03 Aug 2005 13:43:07 +0200 |
| |
On Tue, 2005-08-02 at 08:40 -0600, Eric W. Biederman wrote: > Pavel Machek <pavel@ucw.cz> writes: > > > Hi! > > > >> Why are we calling driver suspend routines in these ? This is _not_ > > > > Well, reason is that if you remove device_suspend() you'll get > > emergency hard disk park during powerdown. As harddrives can survive > > only limited number of emergency stops, that is not a good idea. > > Then the practical question is: do we suspend the disk by > calling device_suspend() for every device. Or do we modify > the ->shutdown() method for the disk.
afaik, IDE used to have a shutdown callback or a shutdown notifier already anyway. If that was lost, then this is a different problem. If SATA and/or SCSI aren't doing it, then they need fixing, but suspend() isn't the solution.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |