lkml.org 
[lkml]   [2005]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: 2.6.13-rc7-git2 crashes on iBook
    From
    Date
    Le dimanche 28 août 2005 à 22:02 -0600, Alex Williamson a écrit :
    > On Sun, 2005-08-28 at 13:20 +0200, Andreas Schwab wrote:
    > > The last change to drivers/pci/setup-res.c (Ignore disabled ROM resources
    > > at setup) is breaking radeonfb on iBook G3 (with Radeon Mobility M6 LY).
    > > It crashes in pci_map_rom when called from radeonfb_map_ROM. This is
    > > probably a dormant bug that was just uncovered by the change.
    >
    > Same thing on Mac Mini. 2.6.13 doesn't boot. Revert the
    > drivers/pci/setup-res.c change from rc7-git2 and it seems ok.

    Confirmed on an Apple Powerbook too.

    For reference, the (already reverted) patch which needs to be applied is
    below.

    Signed-off-by: Stelian Pop <stelian@popies.net>

    Index: linux-2.6.git/drivers/pci/setup-res.c
    ===================================================================
    --- linux-2.6.git.orig/drivers/pci/setup-res.c 2005-08-29 10:03:00.000000000 +0200
    +++ linux-2.6.git/drivers/pci/setup-res.c 2005-08-29 12:23:20.980716336 +0200
    @@ -53,9 +53,7 @@
    if (resno < 6) {
    reg = PCI_BASE_ADDRESS_0 + 4 * resno;
    } else if (resno == PCI_ROM_RESOURCE) {
    - if (!(res->flags & IORESOURCE_ROM_ENABLE))
    - return;
    - new |= PCI_ROM_ADDRESS_ENABLE;
    + new |= res->flags & IORESOURCE_ROM_ENABLE;
    reg = dev->rom_base_reg;
    } else {
    /* Hmm, non-standard resource. */
    Stelian.
    --
    Stelian Pop <stelian@popies.net>

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-08-29 12:42    [W:0.020 / U:30.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site