Messages in this thread | | | Date | Mon, 29 Aug 2005 11:49:45 -0700 | From | Tom Rini <> | Subject | Re: [patch 08/16] Add support for X86_64 platforms to KGDB |
| |
On Mon, Aug 29, 2005 at 08:46:15PM +0200, Andi Kleen wrote: > On Monday 29 August 2005 19:45, Tom Rini wrote: > > > > > Bob did this part (forgot to CC him, oops). But I believe it's needed > > for setting traps so much earlier. > > Ok looking again I guess he needed it for the GDT access in cpu_init > > > > > + if (notify_die(DIE_PAGE_FAULT, "no context", regs, error_code, 14, > > > > + SIGSEGV) == NOTIFY_STOP) > > > > + return; > > > > + > > > > > > I can see the point of that. It's ok if you submit it as a separate > > > patch. > > > > I can split that out into one that follows the KDB_VECTOR rename easily > > enough. > > That's fine. The rename is fine for me too btw. > > > > > > Regarding early trap init: I would have no problem to move all of > > > traps_init into setup_arch (and leave traps_init empty for generic code). > > > I actually don't know why it runs so late. But doing it half way is ugly. > > > > Should I make setup_per_cpu_area and trap_init empty and turn the real > > ones into early_foo? > > setup_per_cpu_area is still needed later because it needs to allocate for non > BP and you cannot do that that early.
OK. So I'll send out a patch that makes trap_init() empty and use the early_setup_per_cpu_areas() Bob wrote as well.
Andrew: In sum, there will be 3 patches that replace the x86_64 main patch (2 split-out-stuff, 1 new kgdb patch).
-- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |