lkml.org 
[lkml]   [2005]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectWe also need to get rid of verify_area in entry.S
Date
Hi Chris,

In addition to the patch I sent a few minutes ago, there's one last reference
to verify_area left in xtensa. It's in arch/xtensa/kernel/entry.S, and I'm
going to need your help to get rid of that one since that code is over my head
and I assume that the naive approach below would just break it :

diff -upr -X ./linux-2.6.13/Documentation/dontdiff linux-2.6.13-orig/arch/xtensa/kernel/entry.S linux-2.6.13/arch/xtensa/kernel/entry.S
--- linux-2.6.13-orig/arch/xtensa/kernel/entry.S 2005-08-29 01:41:01.000000000 +0200
+++ linux-2.6.13/arch/xtensa/kernel/entry.S 2005-08-29 03:48:43.000000000 +0200
@@ -1102,7 +1102,7 @@ ENTRY(fast_syscall_sysxtensa)
s32i a7, a2, PT_AREG7

movi a7, 4 # sizeof(unsigned int)
- verify_area a3, a7, a0, a2, .Leac
+ access_ok a3, a7, a0, a2, .Leac

_beqi a6, SYSXTENSA_ATOMIC_SET, .Lset
_beqi a6, SYSXTENSA_ATOMIC_EXG_ADD, .Lexg
So, could you come up with a working patch and push it to Andrew along with the
one I sent a little while ago, so I can push my verify_area removal patches? Or
you can just sign off on my previous patch if it's OK, and send me one for
entry.S and then I'll push the entire thing onwards if you prefer that.
Thanks in advance.


--
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-29 19:58    [W:0.422 / U:0.216 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site