lkml.org 
[lkml]   [2005]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH scsi-misc 2/2] megaraid_sas: LSI Logic MegaRAID SAS RAID D river
Looks pretty good to me.  Small issues I've identified:

- what do you need the hba_count attribute for? This should be
implementable in userspace pretty easily by iterating of all
devices of the scsi_host class that are attached to the driver
- the ->queuecommand cleanup patch I sent you a awhile ago doesn't
seem to be applied
- there's quite a lot of slightly odd formating, it would be nice
if you could run the code through scripts/Lindent.

If you could sent out an unmangled patch (even as attachment or on
LSI's ftp side) I'd like to take another, closer look.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-29 19:10    [W:0.129 / U:3.064 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site