lkml.org 
[lkml]   [2005]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [ACPI] acpi_shutdown: Only prepare for power off on power_off
From
Date
Pavel Machek <pavel@ucw.cz> writes:

> Hi!
>
>> When acpi_sleep_prepare was moved into a shutdown method we
>> started calling it for all shutdowns. It appears this triggers
>> some systems to power off on reboot. Avoid this by only calling
>> acpi_sleep_prepare if we are going to power off the system.
>
> Are you sure that system_state is correctly set at this point? There are
> quite a few ways that lead to this...

- It is an error if system_state is not set properly.

- Do to my earlier cleanups there are only 4 functions
that call device_shutdown they are:
kernel_restart(), kernel_kexec(), kernel_halt(), kernel_power_off()

And those four all set system_state correctly.

If you can find another path that calls this incorrectly I would be happy
to fix it. But my grep through the kernel doesn't reveal any other
callers.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-27 21:56    [W:0.081 / U:8.296 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site