[lkml]   [2005]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] acpi: Handle cpu_index greater than 256 properly in processor_core.c
Hi Venkatesh,

On Saturday 27 August 2005 02:07, Venkatesh Pallipadi wrote:
> Fix convert_acpiid_to_cpu function to handle cpu_index greater than 256. This
> patch also prevents a warning in IA64 cross-compile of this file
> (drivers/acpi/processor_core.c:517: warning: comparison is always false due
> to limited range of data type).

Why don't you just change the datatype to "unsigned int" and
the return failure value to NR_CPUS?

That reduces the code changes and leaves the code quite clear.
It should also reduce compiled code size by some bytes, but I'm not
sure about that one.


Ingo Oeser

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2005-08-27 14:26    [W:0.030 / U:3.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site