lkml.org 
[lkml]   [2005]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] pipe: do not return POLLERR for fifo_poll
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> > This patch changes fifo_poll not to return POLLERR to take care of a FIXME
> > in fs/pipe.c stating that "Most unices do not set POLLERR for fifos." The
> > comment has been there since 2.3.99-pre3 so either apply this patch or
> > alternatively, I can send a new one removing the unnecessary abstraction.

On Thu, 25 Aug 2005, Andrew Morton wrote:
> A userspace-visible change, no?
>
> So there's a risk in changing it. What do we get in return? Worried.

FWIW I have been running on this for few days now without any noticeable
regressions. We get a solved FIXME in return but like I said I am a happy
to remove the redundant abstraction if this is too risky.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-26 09:05    [W:0.032 / U:0.916 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site