lkml.org 
[lkml]   [2005]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
Jan Blunck <j.blunck@tu-harburg.de> wrote:
>
> IMO sys_readahead() doesn't make sense if the file is opened with
> O_DIRECT, because the page cache is stuffed but never used. Therefore
> this patch changes that by letting the call return with -EINVAL.
>

a) It doesn't hurt, it's just a bit of a silly thing to do.

b) posix_fadvise(POSIX_FADV_WILLNEED) should get the same treatment (and
it's the preferred way of doing readahead).

c) O_DIRECT fd's should, as much as possible, offer the same ABI as
buffered fd's.

d) The patch could break existing apps.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-25 10:28    [W:0.098 / U:3.636 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site