lkml.org 
[lkml]   [2005]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RESEND] don't allow sys_readahead() on files opened with O_DIRECT
On Thu, Aug 25, 2005 at 01:24:40AM -0700, Andrew Morton wrote:
> > IMO sys_readahead() doesn't make sense if the file is opened with
> > O_DIRECT, because the page cache is stuffed but never used. Therefore
> > this patch changes that by letting the call return with -EINVAL.
> >
>
> a) It doesn't hurt, it's just a bit of a silly thing to do.

For ocfs that only allows either direct or buffered I/O on a single
inode at a given time it hurts. It messes up the synchronization
protocol to be exact..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-25 14:49    [W:0.042 / U:7.740 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site