Messages in this thread | | | Date | Wed, 24 Aug 2005 15:01:46 -0700 | From | Chris Wright <> | Subject | Re: [UPDATED] Re: [PATCH 1/5] Add pagetable allocation notifiers |
| |
* Zachary Amsden (zach@vmware.com) wrote: > Done. Looks like you want empty_zero_page write protected too. That > seems like a fine idea to me unless something really wants to do atomic > 64-bit reads on it.
Thanks, I added this set (minus the 3/5, which I already have) to the virt-2.6 tree.
> The -1 is quite useless when you're going to shift >> 12 anyways to get > a frame number to index into mem_map, which is why they are not there. > Plus, it just seems scary if you got it wrong - let's say you had a not > present page - not that you could, but now you are freeing a misaligned > address in the _previous_ page. I really don't like that -1 at all. I > will clean it up, but it does certainly deserve another patch.
Heh, that's exactly what I was concerned with from the patch (being on the wrong page). Thanks for clearing up my confusion.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |