lkml.org 
[lkml]   [2005]   [Aug]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Add MCE resume under ia32
    FromShaohua Li <>
    DateWed, 24 Aug 2005 12:16:26 +0800
    On Wed, 2005-08-24 at 05:59 +0200, Andi Kleen wrote:
    > [adding discuss to cc]
    > 
    > On Wednesday 24 August 2005 05:47, Shaohua Li wrote:
    > > On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote:
    > > > On Wednesday 24 August 2005 03:59, Shaohua Li wrote:
    > > > > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote:
    > > > > > Shaohua Li <shaohua.li@intel.com> writes:
    > > > > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method,
    > > > > > > which is known broken. We'd better fix it.
    > > > > >
    > > > > > What is broken with it?
    > > > >
    > > > > It's a sysdev. The resume method is invoked with interrupt disabled.
    > > >
    > > > But only local interrupt disabled, no?
    > > >
    > > > Hmm - didn't we have a WARN_ON(irqs_disabled()) in smp_call_function().
    > > >
    > > > Anyways, it'll probably still work for now because the system should
    > > > be synchronized at this point.
    > >
    > > We are using cpu hotplug framework for MP suspend/resume. When sysdev's
    > > resume is calling, APs actually aren't up. So it actually can't work.
    > 
    > Ok, that's a new problem.
    > 
    > There were recently some patches to add individual MCE entries
    > for each CPU to sysfs. They are only used for set up right now,
    > but perhaps they can be linked somehow to the cpu sysfs devices
    > and get suspend/resume events from there.
    The boot code already initialized MCE for APs, it isn't required to
    initialize again. The MCE entries are cpuhotplug friendly, so for
    suspend/resume.
    
    Thanks,
    Shaohua
    
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2005-08-24 06:16    [from the cache]
    ©2003-2008