lkml.org 
[lkml]   [2005]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c
Date
Convert strtok() use to strsep() in usr/gen_init_cpio.c

I've compile tested this patch and it compiles fine.
I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and
the resulting kernel boots and runs just fine (using it right now).
But despite this basic testing it would still be nice if someone would
double-check that I haven't made some silly mistake that would break some
other setup than mine.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
gen_init_cpio.c | 31 ++++++++++++++++++++++---------
1 files changed, 22 insertions(+), 9 deletions(-)
--- linux-2.6.13-rc6-mm2-orig/usr/gen_init_cpio.c 2005-06-17 21:48:29.000000000 +0200
+++ linux-2.6.13-rc6-mm2/usr/gen_init_cpio.c 2005-08-24 18:58:21.000000000 +0200
@@ -438,7 +438,7 @@ struct file_handler file_handler_table[]
int main (int argc, char *argv[])
{
FILE *cpio_list;
- char line[LINE_SIZE];
+ char *line, *ln;
char *args, *type;
int ec = 0;
int line_nr = 0;
@@ -455,7 +455,14 @@ int main (int argc, char *argv[])
exit(1);
}

- while (fgets(line, LINE_SIZE, cpio_list)) {
+ ln = malloc(LINE_SIZE);
+ if (!ln) {
+ fprintf(stderr,
+ "ERROR: unable to allocate %d bytes of buffer\n", LINE_SIZE);
+ exit(1);
+ }
+
+ while (line = ln, fgets(line, LINE_SIZE, cpio_list)) {
int type_idx;
size_t slen = strlen(line);

@@ -466,14 +473,15 @@ int main (int argc, char *argv[])
continue;
}

- if (! (type = strtok(line, " \t"))) {
+ if (! (type = strsep(&line, " \t"))) {
fprintf(stderr,
"ERROR: incorrect format, could not locate file type line %d: '%s'\n",
- line_nr, line);
+ line_nr, ln);
ec = -1;
+ continue;
}

- if ('\n' == *type) {
+ if (!*type || '\n' == *type) {
/* a blank line */
continue;
}
@@ -483,16 +491,20 @@ int main (int argc, char *argv[])
continue;
}

- if (! (args = strtok(NULL, "\n"))) {
+ if (! (args = strsep(&line, "\n"))) {
fprintf(stderr,
"ERROR: incorrect format, newline required line %d: '%s'\n",
- line_nr, line);
+ line_nr, ln);
ec = -1;
+ continue;
}
+
+ if (!*args)
+ continue;

for (type_idx = 0; file_handler_table[type_idx].type; type_idx++) {
int rc;
- if (! strcmp(line, file_handler_table[type_idx].type)) {
+ if (! strcmp(type, file_handler_table[type_idx].type)) {
if ((rc = file_handler_table[type_idx].handler(args))) {
ec = rc;
fprintf(stderr, " line %d\n", line_nr);
@@ -503,9 +515,10 @@ int main (int argc, char *argv[])

if (NULL == file_handler_table[type_idx].type) {
fprintf(stderr, "unknown file type line %d: '%s'\n",
- line_nr, line);
+ line_nr, ln);
}
}
+ free(ln);
cpio_trailer();

exit(ec);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-24 21:11    [W:0.172 / U:0.124 seconds]
©2003-2014 Jasper Spaans. Advertise on this site