lkml.org 
[lkml]   [2005]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Add MCE resume under ia32
    From
    Date
    On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote:
    > On Wednesday 24 August 2005 03:59, Shaohua Li wrote:
    > > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote:
    > > > Shaohua Li <shaohua.li@intel.com> writes:
    > > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method,
    > > > > which is known broken. We'd better fix it.
    > > >
    > > > What is broken with it?
    > >
    > > It's a sysdev. The resume method is invoked with interrupt disabled.
    >
    > But only local interrupt disabled, no?
    >
    > Hmm - didn't we have a WARN_ON(irqs_disabled()) in smp_call_function().
    >
    > Anyways, it'll probably still work for now because the system should
    > be synchronized at this point.
    We are using cpu hotplug framework for MP suspend/resume. When sysdev's
    resume is calling, APs actually aren't up. So it actually can't work.

    Thanks,
    Shaohua

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-08-24 05:47    [W:0.021 / U:1.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site