lkml.org 
[lkml]   [2005]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: suspicious behaviour in pcwd driver.
From
Date

> Export machine_power_off() on ppc64, as the pcwd watchdog driver needs it.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.12/arch/ppc64/kernel/setup.c~ 2005-08-09 17:37:36.000000000 -0400
> +++ linux-2.6.12/arch/ppc64/kernel/setup.c 2005-08-09 17:37:53.000000000 -0400
> @@ -706,6 +706,7 @@ void machine_power_off(void)
> local_irq_disable();
> while (1) ;
> }
> +EXPORT_SYMBOL(machine_power_off);
>
> void machine_halt(void)
> {
>

In fact, we need that for the G5 thermal driver too. I wonder why/how
this export got removed ... Some over-zealous janitors ?

Hrm... /me plays with gitk

Ahhh, ok, so that is this patch:

<<
machine_restart, machine_halt and machine_power_off are machine
specific hooks deep into the reboot logic, that modules
have no business messing with. Usually code should be calling
kernel_restart, kernel_halt, kernel_power_off, or
emergency_restart. So don't export machine_restart,
machine_halt, and machine_power_off so we can catch buggy users.
>>

Well, I think for now, it's safe for therm_pm72 to call
machine_power_off() in case of critical overtemp. I'll have a look at
kernel_* equivalents later.

Can you still slip that patch into 2.6.13 ?

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-23 01:29    [W:0.107 / U:1.580 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site