Messages in this thread | | | Date | Thu, 18 Aug 2005 15:15:43 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [git patches] ide update |
| |
On Thu, 18 Aug 2005, Bartlomiej Zolnierkiewicz wrote: > > 3 obvious fixes + support for 2 new controllers > (just new PCI IDs).
Btw, things like this:
+#define IDEFLOPPY_TICKS_DELAY HZ/20 /* default delay for ZIP 100 (50ms) */
are just bugs waiting to happen.
Hint: see what happens when you do something like this:
high_byte = IDEFLOPPY_TICKS_DELAY >> 8; low_byte = (unsigned char) IDEFLOPPY_TICKS_DELAY;
and watch in amazement how you get entirely the wrong value if HZ is 1000.
Try it out..
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |