lkml.org 
[lkml]   [2005]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] ide update


On Thu, 18 Aug 2005, Bartlomiej Zolnierkiewicz wrote:
>
> 3 obvious fixes + support for 2 new controllers
> (just new PCI IDs).

Btw, things like this:

+#define IDEFLOPPY_TICKS_DELAY HZ/20 /* default delay for ZIP 100 (50ms) */

are just bugs waiting to happen.

Hint: see what happens when you do something like this:

high_byte = IDEFLOPPY_TICKS_DELAY >> 8;
low_byte = (unsigned char) IDEFLOPPY_TICKS_DELAY;

and watch in amazement how you get entirely the wrong value if HZ is 1000.

Try it out..

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.046 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site