lkml.org 
[lkml]   [2005]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2.6.13-rc6] watchdog: fix oops in softdog driver
Hi Chuck,

> The softdog watchdog timer has a bug that can create an oops:
>
> 1. Load the module without the nowayout option.
> 2. Open the driver and close it without writing 'V' before close.
> 3. Unload the module. The timer will continue to run...
> 4. Oops happens when timer fires.
>
> Reported Sun, 10 Oct 2004, by Michael Schierl <schierlm@gmx.de>
>
> Fix is easy: always take a reference on the module on open.
> Release it only when the device is closed and no timer is running.
> Tested on 2.6.13-rc6 using the soft_noboot option. While the
> timer is running and the device is closed, the module use count
> stays at 1. After the timer fires, it drops to 0. Repeatedly
> opening and closing the driver caused no problems. Please apply.

I'll add this to the watchdog tree.

Thanks,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-08-18 20:43    [W:0.035 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site