Messages in this thread | | | Date | Thu, 18 Aug 2005 12:52:24 +1000 | From | Nick Piggin <> | Subject | Re: [PATCH] struct file cleanup : the very large file_ra_state is now allocated only on demand. |
| |
Andi Kleen wrote:
> >I would just set the ra pointer to a single global structure if the allocation >fails. Then you can avoid all the other checks. It will slow down >things and trash some state, but not fail and nobody should expect good >performance after out of memory anyways. The only check still >needed would be on freeing. > >
You don't want to always have bad performance though, so you could attempt to allocate if either the pointer is null _or_ it points to the global structure?
Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |