Messages in this thread Patch in this message | | | From | Tom Zanussi <> | Date | Mon, 15 Aug 2005 09:58:40 -0500 | Subject | Re: [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode |
| |
Hareesh Nagarajan writes: > Hi Andrew, > > The overwrite arg has been removed from the relay_subbufs_consumed() > (since it has been removed from relayfs altogether) so the comment > preceding the function must go.
relayfs still supports overwrite mode, but it's now implemented differently (via the subbuf_start() callback instead of an overwrite arg), so this comment is still valid.
Tom
> > Thanks, > > Hareesh > diff -ruN linux-akpm/fs/relayfs/relay.c linux/fs/relayfs/relay.c > --- linux-akpm/fs/relayfs/relay.c 2005-08-14 21:16:35.000000000 -0700 > +++ linux/fs/relayfs/relay.c 2005-08-14 21:26:10.000000000 -0700 > @@ -342,9 +342,6 @@ > * Adds to the channel buffer's consumed sub-buffer count. > * subbufs_consumed should be the number of sub-buffers newly consumed, > * not the total consumed. > - * > - * NOTE: kernel clients don't need to call this function if the channel > - * mode is 'overwrite'. > */ > void relay_subbufs_consumed(struct rchan *chan, > unsigned int cpu,
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |