Messages in this thread | | | Subject | Re: [patch] inotify: idr_get_new_above not working? | From | John McCutchan <> | Date | Mon, 15 Aug 2005 12:35:12 -0400 |
| |
On Mon, 2005-08-15 at 12:27 -0400, Robert Love wrote: > On Mon, 2005-08-15 at 10:16 -0400, John McCutchan wrote: > > > Inotify is using idr_get_new_above to make sure that the next watch > > descriptor is larger/different than any of the previous watch > > descriptors. We keep track of the largest wd that we get out of > > idr_get_new_above, and pass that to idr_get_new_above. I have noticed > > though, that idr_get_new_above always returns the first available id. > > This causes a serious problem for inotify, because user space will get a > > IGNORE event for a wd K that might refer to the last holder of the K. > > Turns out that the problem was in our court and not the idr layer. > idr_get_new_above() seems to work fine. > > One-line patch is attached. Please merge before 2.6.13.
My bad! Patch looks correct.
Signed-off-by: John McCutchan <ttb@tentacle.dhs.org>
-- John McCutchan <ttb@tentacle.dhs.org> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |