lkml.org 
[lkml]   [2005]   [Aug]   [12]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateFri, 12 Aug 2005 12:51:17 +0400
    FromOleg Nesterov <>
    SubjectRe: [RFC,PATCH] Use RCU to protect tasklist for unicast signals
    Paul E. McKenney wrote:
    >
    > --- linux-2.6.13-rc4-realtime-preempt-V0.7.53-01/fs/exec.c	2005-08-11 11:44:55.000000000 -0700
    > +++ linux-2.6.13-rc4-realtime-preempt-V0.7.53-01-tasklistRCU/fs/exec.c	2005-08-11 12:26:45.000000000 -0700
    > [ ... snip ... ]
    > @@ -785,11 +787,13 @@ no_thread_group:
    >  		recalc_sigpending();
    > 
    > +		oldsighand->deleted = 1;
    > +		oldsighand->successor = newsighand;
    
    I don't think this is correct.
    
    This ->oldsighand can be shared with another CLONE_SIGHAND
    process and will not be deleted, just unshared.
    
    When the signal is sent to that process we must use ->oldsighand
    for locking, not the oldsighand->successor == newsighand.
    
    Oleg.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2005-08-12 10:43    [from the cache]
    ©2003-2008